Azure pipelines #373
Azure pipelines #373
Conversation
|
@vhatsura thank you for submitting this PR, I really appreciate it. Just to make you aware, my main focus just now is updating current known uses of Cake.Recipe (mainly in the Cake-Contrib Organisation) to use a pinned version of Cake.Recipe so that any incoming breaking changes don't affect any upstream callers who aren't pinned to the "released" version. Once that is done, I plan on looking at merging PR's. Thanks for your understanding. |
There was a problem hiding this comment.
Another thing which needs to be updated for Azure Pipelines is that Codecov doesn't require a Token on Azure Pipelines here
|
@pascalberger actually, you still need to specify the token when running on Azure Pipelines. The only CI's that don't need a token is Appveyor, Travis CI (coming in next version of codecov-exe) and circle-ci (not yet on the roadmap). |
|
Hey, @gep13. How's going your work with updating upstreams? Is it any chance that you can review this PR in near month? It's long awaited feature from various cake add in and it would be nice to complete work with support of azure pipelines. |
|
@vhatsura we are getting there. You can see the progress in the Audit spreadsheet here: https://github.com/cake-contrib/Home/blob/master/Audit.xlsx Filter by the end column, with regard to what version of Cake.Recipe is being used. Without checking, I believe that there are 22 addins remaining to be updated, but this list started out at over 80 I think, so progress is being made 😄 In the meantime, there would be nothing to stop you using a custom build of Cake.Recipe with your changes in it, this would be good to work through any teething issues. I know that @AdmiringWorm is doing that on a couple of his addins, ahead of those changes getting pulled into Cake.Recipe for the next release. |
|
@vhatsura your changes have been merged, thanks for your contribution 👍 |
This PR adds support for running cake.recipe on AzurePipelines with all main features. (another part of #259)
Test run on AzurePipelines you can check here, which is built from custom branch in fork
Changes:
Numberproperty ofIBuildInfointerface was changed frominttostring(BuildNumber on AzurePipelines is string)IBuildProviderinterface is extended byUploadArtifact(FilePath file)methodIBuildProviderfor AzurePipelinesUploadAppVeyorArtifactsTaskrenamed toUploadArtifactsTask("Upload-AppVeyor-Artifacts" -> "Upload-Artifacts")Open questions:
AppVeyor. I didn't rename it due to backward compatibility. What we need to do it with it, because if I want to run my cake on AzurePipelines with Cake.Recipe I need to callAppVeyourtarget, which is a litle bit confusing.